Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-core): incorrect callback parameters when reactive array ref passes to watch #9417

Closed
wants to merge 2 commits into from

Conversation

Dunqing
Copy link
Contributor

@Dunqing Dunqing commented Oct 17, 2023

close: #9416

@github-actions
Copy link

github-actions bot commented Oct 17, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+27 B) 32.7 kB (+28 B) 29.5 kB (+17 B)
vue.global.prod.js 132 kB (+27 B) 49.4 kB (+22 B) 44.3 kB (-43 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB (+27 B) 18.9 kB (+17 B) 17.2 kB (+64 B)
createSSRApp 50.7 kB (+27 B) 20 kB (+17 B) 18.2 kB (+18 B)
defineCustomElement 50.3 kB (+27 B) 19.7 kB (+14 B) 17.9 kB (+20 B)
overall 61.3 kB (+27 B) 23.7 kB (+23 B) 21.6 kB (+21 B)

@skirtles-code
Copy link
Contributor

I don't think these changes can be merged. Changing the runtime behaviour for watching a reactive array will break too many real applications.

I found it interesting that the changes proposed here didn't trigger any test failures. I opened #10848 (now merged) to try to address that. Several of those tests would fail if the changes proposed here were merged.

I don't have any suggestions for how to fix the original issue. The types are inconsistent with the runtime values, but we can't change the runtime values. I'm not sure whether fixing it in the types is possible.

@yyx990803
Copy link
Member

Closing as #9416 is indeed a type issue.

@yyx990803 yyx990803 closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

watch callback arg has incorrect type for reactive array containing refs
3 participants