fix(types): Use alternative Omit that enables discriminated unions in props

[davidmatter]

This resolves #9335

We use an alternative Omit that doesn't break discriminated unions when using withDefaults. More information can be found here: microsoft/TypeScript#31501

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
sfc-playground	✅ Ready (Inspect)	Visit Preview	Oct 4, 2023 8:55am

[github-actions]

Size Report

Bundles

File	Size	Gzip	Brotli
runtime-dom.global.prod.js	90.1 kB	34.5 kB	31.1 kB
vue.global.prod.js	147 kB	54 kB	48 kB

Usages

Name	Size	Gzip	Brotli
createApp	49.6 kB	19.5 kB	17.8 kB
createSSRApp	53.2 kB	20.9 kB	19.1 kB
defineCustomElement	51.9 kB	20.2 kB	18.5 kB
overall	63.1 kB	24.5 kB	22.3 kB

[pikax]

@davidmatter looks good, but wondering why there's changes on the import order, can you rollback changes on the order please

[davidmatter]

@pikax thanks, rolled back the import ordering

[davidmatter]

@pikax The pendant fix in language tools has been merged in vuejs/language-tools#3672. Would be cool if this one could be merged too. Thanks!

[davidmatter]

@pikax do you know when this one will be merged?

[skirtles-code]

It looks like this may have been fixed by another PR, #10596.

The fixes look fairly different and my TS knowledge isn't good enough to assess the differences between them. Is there any benefit to pursuing the approach in this PR over what's currently on main?

[davidmatter]

According to the ts team #10596 is the way to go. Not sure if there are any important differences for this usecase between my proposal of

type OmitKeepDiscriminatedUnion<T, K extends keyof any> = T extends any ? Pick<T, Exclude<keyof T, K>> : never

and the one in #10596

type MappedOmit<T, K extends keyof any> = { [P in keyof T as P extends K ? never : P]: T[P] }

Feel free to either close this one or, IMO even better, we could just merge my testcase without the Omit helper as it specifically tests the usage of discriminated unions.