Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): component type check when props is an empty object #7419

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

rudyxu1102
Copy link
Contributor

@rudyxu1102 rudyxu1102 commented Dec 27, 2022

Fixes #4051
Fixes #8825

TS Playground

playground

Problem

microsoft/TypeScript#52037

@github-actions
Copy link

github-actions bot commented Sep 4, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 99.1 kB 37.5 kB 33.8 kB
vue.global.prod.js 157 kB 57.3 kB 51 kB

Usages

Name Size Gzip Brotli
createApp 54.5 kB 21.1 kB 19.3 kB
createSSRApp 58.5 kB 22.8 kB 20.8 kB
defineCustomElement 59.1 kB 22.6 kB 20.6 kB
overall 68.1 kB 26.2 kB 23.9 kB

@yyx990803
Copy link
Member

This is superseded by #10801

@yyx990803 yyx990803 closed this Aug 28, 2024
@yyx990803 yyx990803 reopened this Aug 28, 2024
@yyx990803 yyx990803 merged commit d6ccce9 into vuejs:main Aug 28, 2024
11 of 12 checks passed
@yyx990803
Copy link
Member

Merged for the test case. Thank you!

Copy link

pkg-pr-new bot commented Aug 28, 2024

commit: 02a5ef3

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@7419

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@7419

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@7419

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@7419

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@7419

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@7419

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@7419

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@7419

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@7419

vue

pnpm add https://pkg.pr.new/vue@7419

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@7419

Open in Stackblitz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants