Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): never skip Function prop type #7112

Merged
merged 2 commits into from
Nov 14, 2022
Merged

fix(compiler-sfc): never skip Function prop type #7112

merged 2 commits into from
Nov 14, 2022

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Nov 12, 2022

closes #7111

@sxzz sxzz added the 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. label Nov 12, 2022
@sxzz sxzz requested a review from yyx990803 November 12, 2022 04:48
@sxzz
Copy link
Member Author

sxzz commented Nov 14, 2022

Wait a moment @yyx990803

@yyx990803 yyx990803 merged commit 584eae6 into vuejs:main Nov 14, 2022
@sxzz sxzz deleted the fix/function-props-type branch November 14, 2022 00:36
@yyx990803
Copy link
Member

😅 didn't see it when I hit the merge button

@sxzz
Copy link
Member Author

sxzz commented Nov 14, 2022

Never mind. I just thought of a better solution for the case of the static default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The type of props will be discard when using typed-macros
2 participants