Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customElement): support for expose on customElement, fix #5540 #6256

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

hcg1023
Copy link
Contributor

@hcg1023 hcg1023 commented Jul 12, 2022

fix #5540

@itwondersteam
Copy link

any sign that this PR will get updated and get merged? bumped into this issue today as the defineExpose currently is not behaves consistently.

@GuoJikun
Copy link

This feature is much needed

@Ttou
Copy link

Ttou commented May 29, 2023

hope merged quickly

@amantiwari1
Copy link

amantiwari1 commented Sep 18, 2023

This pull request needs to be merged promptly, and it has been open for one year and three months. cc: @yyx990803

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit 3ca5b98
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/65123ffefe5ad30008a4f3d8

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit 3ca5b98
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/65123ffe1d63f20008c38601

@hcg1023
Copy link
Contributor Author

hcg1023 commented Sep 21, 2023

I fixed the conflict on the branch

@yyx990803 yyx990803 changed the base branch from main to minor August 3, 2024 06:31
Copy link

github-actions bot commented Aug 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 97.3 kB (+7.2 kB) 37 kB (+2.41 kB) 33.3 kB (+2.13 kB)
vue.global.prod.js 155 kB (+8.16 kB) 56.7 kB (+2.7 kB) 50.5 kB (+2.43 kB)

Usages

Name Size Gzip Brotli
createApp 53.8 kB (+4.19 kB) 20.9 kB (+1.38 kB) 19 kB (+1.21 kB)
createSSRApp 57.8 kB (+4.57 kB) 22.5 kB (+1.52 kB) 20.4 kB (+1.34 kB)
defineCustomElement 57.2 kB (+5.26 kB) 22 kB (+1.73 kB) 20 kB (+1.52 kB)
overall 67.4 kB (+4.25 kB) 25.9 kB (+1.39 kB) 23.5 kB (+1.25 kB)

@yyx990803 yyx990803 merged commit af838c1 into vuejs:minor Aug 3, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

Methods exposed with defineExpose are not available on custom element
7 participants