fix(Transition): Make transition behavior in KeepAlive in dev-mode consistent with production-mode. #5557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consistent with production-mode.
✅ Deploy Preview for vue-sfc-playground ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vuejs-coverage ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for vue-next-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
is this same as #5268 ?🤔 |
Not exactly, because components are not uninstalled in keepalive, but I believe there should be a similar problem in 5268. |
edison1105
changed the title
|
Could you please resolve the conflicts? |
edison1105
reviewed
Oct 23, 2024
| if ( | ||
| __DEV__ && | ||
| patchFlag > 0 && | ||
| patchFlag & PatchFlags.DEV_ROOT_FRAGMENT |
There was a problem hiding this comment.
It will not work if keep comments in the production build.
edison1105
added
🍰 p2-nice-to-have
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #5500
In this example, click Page A and then click Page B. Page A moves to the left, which is inconsistent with the name of the Transition node.This is due to the fact that
core/packages/runtime-core/src/componentRenderUtils.ts
Lines 221 to 229 in 5898629
It adjusts the position of the transition, so the last transition is used when moving. Now let's update it manually