fix: Ref transform being applied to variables named hasOwnProperty
.
#4515
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the variable
var hasOwnProperty = Object.prototype.hasOwnProperty
running through the transformer will result inhttps://github.com/vuejs/vue-next/blob/master/packages/ref-transform/src/refTransform.ts#L313
id.name
beinghasOwnProperty
which will return truthy for all objects. So instead we check for strict equality. We will only get properties flaggedtrue
in the scope passing through to be transformed.This problem is blowing up all applications when using
refTransform: true
as @vue/shared is doing this exact thing herehttps://github.com/vuejs/vue-next/blob/master/packages/shared/src/index.ts#L54
When running vite in dev mode the line below is being transformed to
This small update will fix that.