fix(shared): normalize undefined styles to empty object #4424
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, setting
v-bind:style
to a value that can compute to undefined will remove any styles on the element when it does return undefined. I ran into this issue when usingv-show
along with anundefined
style binding.This patch makes it so that the
normalizeStyle
function will convert undefined/null bindings to an empty object instead. I feel like this is a good place to add the check, but it is my first patch on this repo. If anyone can think of a better place to do this, I will change it.