Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): should not take unmount children fast path in de-opt mode #4186

Closed
wants to merge 3 commits into from
Closed

fix(runtime-core): should not take unmount children fast path in de-opt mode #4186

wants to merge 3 commits into from

Conversation

edison1105
Copy link
Member

fix #4183

@edison1105 edison1105 changed the title fix(runtime-core): avoid set dynamicChildren to an empty array fix(runtime-core): need checking optimized when unmount in optimized model Jul 25, 2021
@edison1105 edison1105 changed the title fix(runtime-core): need checking optimized when unmount in optimized model fix(runtime-core): need checking optimized before unmount dynamic children Jul 25, 2021
@edison1105 edison1105 force-pushed the fix/4183 branch 3 times, most recently from 3f7be5b to 848022b Compare July 25, 2021 13:18
@edison1105 edison1105 mentioned this pull request Jul 27, 2021
Closed
@edison1105 edison1105 changed the title fix(runtime-core): need checking optimized before unmount dynamic children fix(runtime-core): should not take unmount children fast path if optimized is false Jul 27, 2021
@edison1105 edison1105 changed the title fix(runtime-core): should not take unmount children fast path if optimized is false fix(runtime-core): should not take unmount children fast path in de-opt mode Jul 27, 2021
@yyx990803
Copy link
Member

Good catch in #4183 (comment) - the root cause is we are overwriting dynamicChildren when the suspense slot is itself a block. If it's a block we should just skip overwriting it.

See 51ee84f

@yyx990803 yyx990803 closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Challenging Bug] Teleport cumulates its content when used with Suspense
2 participants
@edison1105 @yyx990803