Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(reactivity): improve reactive effect memory usage #4001

Merged
merged 4 commits into from
Jun 24, 2021
Merged

perf(reactivity): improve reactive effect memory usage #4001

merged 4 commits into from
Jun 24, 2021

Commits on Jun 24, 2021

  1. perf(reactivity): refactor effect for memory usage improvement 

    - Use class implementation for ReactiveEffect
- Avoid options object allocation
- Lazy initailize bound runner function only when necessary

Benchmark showing around ~17% memory saving when creating computed and
watcher instances.
    @yyx990803
    yyx990803 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    cd5c3ef View commit details
    Browse the repository at this point in the history

  2. perf: avoid cost of passing bound runner to effect scheduler 

    - introduces a minor breaking change where the scheduler no
longer receives the bound runner
    @yyx990803
    yyx990803 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    b0447b3 View commit details
    Browse the repository at this point in the history

  3. chore: move comments

    @yyx990803
    yyx990803 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    45e2464 View commit details
    Browse the repository at this point in the history

  4. test: fix edge case

    @yyx990803
    yyx990803 committed Jun 24, 2021
    Configuration menu
    Copy the full SHA
    26f6265 View commit details
    Browse the repository at this point in the history