Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Addressed infinite loop in compiler #3992

Merged
merged 4 commits into from
Jul 15, 2021

Commits on Jun 22, 2021

  1. fix(compiler): Addressed infinite loop in compiler

    The generateCodeFrame function had the chance to infinite loop on windows machines due to how newline sequence lengths were being treated.
    Newline sequence lengths were assumed to be a single character long which is not true on windows machines.
    
    closes 3987
    DV8FromTheWorld committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    0a252fa View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2021

  1. Apply suggestions from code review

    Fixed comment styling
    
    Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
    DV8FromTheWorld and posva committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f75fb2f View commit details
    Browse the repository at this point in the history
  2. fix(compiler): Addressed further line-ending issues

    There were additional places that we needed to take line ending sequences into account to ensure that we placed  the ^^^s exactly where they should be.
    Unix and Windows should now produce identical results.
    
    Additionally, code was modified to handle source that is passed in that does not have a trailing newline character before the end of the source content.
    DV8FromTheWorld committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    a8b9fc6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    600f03d View commit details
    Browse the repository at this point in the history