feat(compiler): take the comments option to fully control whether to keep comment nodes #3395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
approved these changes
Mar 9, 2021
kospl
reviewed
Mar 9, 2021
kospl
suggested changes
Mar 18, 2021
HcySunYang
added
the
🍰 p2-nice-to-have
kospl
approved these changes
Mar 26, 2021
|
Also strange comment text here: |
should be fine now |
|
@HcySunYang Are you planning to fix this PR? |
DV8FromTheWorld
added a commit
to DV8FromTheWorld/vue-next
that referenced
this pull request
Jul 13, 2021
…n development Close: vuejs#3392 Replace: vuejs#3395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close: #3392
This PR does not change any default behavior, but allows the
commentsoption to fully control comment nodes.