fix(rumtime-core): custom dom props should be cloned when cloning a hoisted DOM #3080
Conversation
HcySunYang
changed the title
LinusBorg
added
the
❗ p4-important
| el = vnode.el = hostCloneNode(vnode.el) | ||
| el = hostCloneNode(vnode.el) | ||
| // #3072 | ||
| // should clone custom DOM props, |
There was a problem hiding this comment.
I think that, for reference, can we should make clear that this specific property is added by v-model and also used for <progress> elements.
"custom DOM props" makes it sound more generic than it is.
There was a problem hiding this comment.
Aha, I think there may be more custom DOM props that need to be added in the future, not just _value, for example, for v-show's el._vod, of course, we don’t need to deal with el._vod, but it can be used as an example.
There was a problem hiding this comment.
Yeah there might be others, so it's good to mention that all custom DOM props which are added by Vue should be included here - _value is one we know and can be specific about.
|
I imagine it's pretty hard to write a proper test for this, but can you think of a way to test this? Would like to ship this with the next patch. |
yeah, let me try |
|
I changed the implementation |
close: #3072
related: #3091