fix(runtime-core): enable config options in beforeCreate and setup #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HcySunYang
reviewed
Feb 9, 2021
| } = options | ||
|
|
||
| const publicThis = instance.proxy! | ||
| } = asMixin ? options : publicThis.$options |
There was a problem hiding this comment.
The $options is a merged options, and the merge strategy is decided by the users, this means:
- Unreliable
Users can return any value by customizing the merge strategy, we need to check them. - Logic conflict with applyOptions
Now,applyOptionsis called recursively when initializing options, but$optionsmay contain options from mixins/extends, do we still need recursive calls?
I think we need to carefully redesign, but indeed, this PR looks more reasonable, compared to #2792
HcySunYang
added
the
🔨 p3-minor-bug
|
Finally, I gave a more appropriate solution #3600 |
HcySunYang
removed
the
🔨 p3-minor-bug
|
Thanks for the PR. Apparently this got fixed with e2ca67b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2791
For flexible and be consistent with Vue2.