refactor(compiler-core,runtime-core,shared): use plain-object instead… #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
Oct 14, 2019
ZhangJian-3ti
suggested changes
Oct 15, 2019
yyx990803
requested changes
Oct 15, 2019
CodeDaraW
reviewed
Oct 15, 2019
packages/shared/src/element.ts
Outdated
| import { makeMap } from './makeMap' | ||
|
|
||
| const HTML_TAGS = | ||
| 'html,body,base,head,link,meta,style,title,address,article,aside,footer,header,h1,h2,h3,h4,h5,h6,hgroup,nav,section,div,dd,dl,dt,figcaption,figure,picture,hr,img,li,main,ol,p,pre,ul,a,b,abbr,bdi,bdo,br,cite,code,data,dfn,em,i,kbd,mark,q,rp,rt,rtc,ruby,s,samp,small,span,strong,sub,sup,time,u,var,wbr,area,audio,map,track,video,embed,object,param,source,canvas,script,noscript,del,ins,caption,col,colgroup,table,thead,tbody,td,th,tr,button,datalist,fieldset,form,input,label,legend,meter,optgroup,option,output,progress,select,textarea,details,dialog,menu,menuitem,summary,content,element,shadow,template,blockquote,iframe,tfoot' |
There was a problem hiding this comment.
Seems that your linter doesn't work well, maximum line length is 80.
https://github.com/vuejs/vue-next/blob/1fbb4d22fa168a44a76e31d3fefcf633d5c4c4bf/.prettierrc#L3
|
Hey @ayush987goyal, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
yyx990803
pushed a commit
that referenced
this pull request
Nov 11, 2024
Co-authored-by: Kevin Deng 三咲智子 <sxzz@sxzz.moe>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
Set.has()checks to use plain-object. As mentioned in #275