Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime-dom): use setAttribute to set DOM prop #2803

Closed
wants to merge 2 commits into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Dec 12, 2020

close #2801
I don't know why not use setAttribute here,Is there any special reason?
and why should warn prop set TypeError?

@posva
Copy link
Member

posva commented Dec 12, 2020

I don't think this is a good idea: #2801 (comment)

Note changing attributes once the element is already in the dom does nothing for many elements (e.g. input's value)

@posva posva closed this Dec 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

img tag attributes 'width, height' rendering with 0
2 participants