Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runtime-core): vnode.el is null in watcher after rerendering (fix #2170) #2295

Merged
merged 1 commit into from
Oct 5, 2020
Merged

fix(runtime-core): vnode.el is null in watcher after rerendering (fix #2170) #2295

merged 1 commit into from
Oct 5, 2020

Commits on Oct 3, 2020

  1. fix(runtime-core): vnode.el is null in watcher after rerendering 

    An instance’s `el` property can be `null` inside a watcher after a component was rerendered (e.g. as a result of a changed prop). In an instance’s `update` method, the branch for handling mounted instances doesn’t set the `el` property of what will become the instance’s `vnode` property soon enough. Upon processing of the `updateComponentPreRender` function, the `el` property is then `null` which causes issues in watcher routines that rely on an instance’s `$el` property.
    @kleinfreund
    kleinfreund committed Oct 3, 2020
    Configuration menu
    Copy the full SHA
    f85feae View commit details
    Browse the repository at this point in the history