fix: watch reactive array callback with array of undefined #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
posva
reviewed
Jul 20, 2020
| it('watching single source: array', async () => { | ||
| const array = reactive([] as number[]) | ||
| let dummy | ||
| watch(array, (array, prevArray) => { |
There was a problem hiding this comment.
the test should rather pass a spy jest.fn() and check the amount of times the spy is called and with what arguments
There was a problem hiding this comment.
okay.. let me change it. i just copied from the convention of the previous tests 🙈
tanhauhau
force-pushed
the
tanlh/fix/watch
branch
from
4952349 to
15befd5
Compare
tanhauhau
force-pushed
the
tanlh/fix/watch
branch
from
15befd5 to
6cce240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1655
if check if array first, the array could be a reactive array.