Skip to content

Conversation

alex-snezhko
Copy link
Contributor

Fix fallthrough attributes in Vapor mode when target component has comments in its template root level

Example
Comp.vue

<template vapor>
  <!--comment-->
  <div>Hello</div>
</template>

App.vue

<script setup vapor>
import Comp from './Comp.vue';
</script>

<template>
  <Comp style="color: red;" />
</template>
Screenshot From 2025-10-06 21-28-09

Copy link

coderabbitai bot commented Oct 7, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

github-actions bot commented Oct 7, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84 kB 29.8 kB 26.3 kB
runtime-dom.global.prod.js 104 kB 39.1 kB 35.3 kB
vue.global.prod.js 162 kB 59.3 kB 52.9 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.4 kB 16.9 kB
createApp 56 kB 21.6 kB 19.7 kB
createApp + vaporInteropPlugin 68.7 kB (+104 B) 25.9 kB (+31 B) 23.6 kB (+19 B)
createVaporApp 21.1 kB (+104 B) 8.36 kB (+26 B) 7.64 kB (+22 B)
createSSRApp 60.3 kB 23.3 kB 21.3 kB
defineCustomElement 61 kB 23.1 kB 21.1 kB
overall 70.5 kB 26.8 kB 24.4 kB

Copy link

pkg-pr-new bot commented Oct 7, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13972

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13972

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13972

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13972

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@13972

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13972

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13972

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13972

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@13972

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13972

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13972

vue

npm i https://pkg.pr.new/vue@13972

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13972

commit: 898964c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant