Skip to content

fix(reactivity): respect readonly during ref unwrapping #13905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

fix(reactivity): respect readonly during ref unwrapping #13905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9755f43
fix(reactivity): respect readonly during ref unwrapping
edison1105 Sep 18, 2025
b5de9cc
test: add test
edison1105 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/reactivity/__tests__/readonly.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,16 @@ describe('reactivity/readonly', () => {
expect(obj.r).toBe(ro)
expect(r.value).toBe(ro)
})

test('should keep nested ref readonly', () => {
const items = ref(['one', 'two', 'three'])
const obj = {
o: readonly({
items,
}),
}
expect(isReadonly(obj.o.items)).toBe(true)
})
})

test('should be able to trigger with triggerRef', () => {
Expand Down
3 changes: 2 additions & 1 deletion packages/reactivity/src/baseHandlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,8 @@ class BaseReactiveHandler implements ProxyHandler<Target> {

if (isRef(res)) {
// ref unwrapping - skip unwrap for Array + integer key.
return targetIsArray && isIntegerKey(key) ? res : res.value
const value = targetIsArray && isIntegerKey(key) ? res : res.value
return isReadonly && isObject(value) ? readonly(value) : value
}

if (isObject(res)) {
Expand Down
Loading