Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keep-alive): avoid duplicate mounts of deactivate components #12042

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

yangxiuxiu1115
Copy link
Contributor

try to fix #12017

Copy link

github-actions bot commented Sep 26, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+272 B) 38.1 kB (+80 B) 34.3 kB (+95 B)
vue.global.prod.js 160 kB (+272 B) 58.1 kB (+88 B) 51.6 kB (+78 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 49.3 kB (+191 B) 19 kB (+61 B) 17.4 kB (+101 B)
createApp 55.8 kB (+191 B) 21.5 kB (+58 B) 19.6 kB (+13 B)
createSSRApp 59.9 kB (+191 B) 23.2 kB (+61 B) 21.1 kB (+91 B)
defineCustomElement 60.6 kB (+191 B) 23 kB (+66 B) 21 kB (+16 B)
overall 69.6 kB (+272 B) 26.6 kB (+89 B) 24.2 kB (+80 B)

Copy link

pkg-pr-new bot commented Sep 26, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12042

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12042

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12042

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12042

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12042

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12042

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12042

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12042

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12042

vue

pnpm add https://pkg.pr.new/vue@12042

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12042

commit: 0e48e8d

@edison1105
Copy link
Member

edison1105 commented Sep 26, 2024

I tested the preview package(pnpm add https://pkg.pr.new/vue@12042) of this PR in the reproduction of #12017.
The b.vue is still mounted twice.

@yangxiuxiu1115
Copy link
Contributor Author

It seems that only the examples in the playground have been fixed, I thought they were the same issue

@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft September 26, 2024 15:33
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as ready for review September 26, 2024 15:52
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft September 26, 2024 16:06
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as ready for review September 26, 2024 16:52
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as draft September 27, 2024 02:40
@yangxiuxiu1115 yangxiuxiu1115 marked this pull request as ready for review September 27, 2024 03:08
@edison1105
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 27, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure failure
vuetify success success
vueuse success failure
vue-simple-compiler success success

@yangxiuxiu1115
Copy link
Contributor Author

kind of strange, doesn't seem to have much relevance, might need to merge the master branch 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nested router with nested keepalive will invoke onMouted twice
3 participants