Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(keep-alive): optimize the matching rules when regexp carry flags #11595

Merged
merged 1 commit into from
Aug 13, 2024
Merged

fix(keep-alive): optimize the matching rules when regexp carry flags #11595

merged 1 commit into from
Aug 13, 2024

Conversation

btea
Copy link
Contributor

@btea btea commented Aug 12, 2024

When keep-alive receives a regular expression, I think it should match the component correctly even if the g flag is carried.

@github-actions GitHub Actions
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 98.8 kB (+16 B) 37.4 kB (+4 B) 33.7 kB (-19 B)
vue.global.prod.js 156 kB (+16 B) 57.2 kB (+4 B) 50.8 kB (+9 B)

Usages

Name Size Gzip Brotli
createApp 54.2 kB 21 kB 19.1 kB
createSSRApp 58.2 kB 22.6 kB 20.7 kB
defineCustomElement 58.8 kB 22.5 kB 20.5 kB
overall 67.8 kB (+16 B) 26 kB (+5 B) 23.7 kB (+69 B)

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: keep-alive 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Aug 13, 2024
@yyx990803 yyx990803 merged commit 3653bc0 into vuejs:main Aug 13, 2024
11 checks passed
@btea btea deleted the fix/keep-alive-improve-regexp branch August 13, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: keep-alive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@btea @edison1105 @yyx990803