fix(compiler): Addressed infinite loop in compiler #3992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generateCodeFrame function had the chance to infinite loop on windows machines due to how newline sequence lengths were being treated. Newline sequence lengths were assumed to be a single character long which is not true on windows machines. closes 3987
posva
reviewed
Jun 23, 2021
posva
reviewed
Jun 23, 2021
Fixed comment styling Co-authored-by: Eduardo San Martin Morote <posva@users.noreply.github.com>
There were additional places that we needed to take line ending sequences into account to ensure that we placed the ^^^s exactly where they should be. Unix and Windows should now produce identical results. Additionally, code was modified to handle source that is passed in that does not have a trailing newline character before the end of the source content.
|
Should be good to go 👍 |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generateCodeFrame function had the chance to infinite loop on windows machines due to how newline sequence lengths were being treated.
Newline sequence lengths were assumed to be a single character long which is not true on windows machines.
closes #3987