Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): take the comments option to fully control whether to keep comment nodes #3395

Closed
wants to merge 5 commits into from
Closed

feat(compiler): take the comments option to fully control whether to keep comment nodes #3395

wants to merge 5 commits into from

Conversation

HcySunYang
Copy link
Member

Close: #3392

This PR does not change any default behavior, but allows the comments option to fully control comment nodes.

posva
posva reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better than #3394 and made me realize my mistake in the comment I left there 😅

packages/compiler-core/src/parse.ts Show resolved Hide resolved
@posva posva mentioned this pull request Mar 9, 2021
Closed
kospl
kospl suggested changes Mar 18, 2021
View reviewed changes
packages/compiler-core/src/parse.ts Outdated Show resolved Hide resolved
@HcySunYang HcySunYang added the 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. label Mar 19, 2021
@kospl
Copy link

kospl commented Mar 27, 2021

Also strange comment text here:

https://github.com/vuejs/vue-next/blob/67039b34342d2a00029e1ad0cf8eb98fdfcf0730/packages/compiler-core/src/options.ts#L51-L57

@HcySunYang
Copy link
Member Author

Also strange comment text here

should be fine now

@DV8FromTheWorld
Copy link
Contributor

@HcySunYang Are you planning to fix this PR?
If not I will open a PR with similar changes as I am in need of this fix.

DV8FromTheWorld added a commit to DV8FromTheWorld/vue-next that referenced this pull request Jul 13, 2021
@DV8FromTheWorld
feat(compiler): Allow 'comments' option to effect comment inclusion i…
5e155fc 
…n development

Close: vuejs#3392
Replace: vuejs#3395
@DV8FromTheWorld DV8FromTheWorld mentioned this pull request Jul 13, 2021
Merged
yyx990803 pushed a commit that referenced this pull request Jul 19, 2021
@DV8FromTheWorld
feat(compiler): allow 'comments' option to affect comment inclusion i…
dd0f9d1 
…n dev (#4115)

Close: #3392
Replace: #3395
@yyx990803 yyx990803 closed this Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva left review comments

@kospl kospl kospl approved these changes

@edison1105 edison1105 edison1105 approved these changes

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile function return comments (even if explicitly set "no comments" option)
6 participants
@HcySunYang @kospl @DV8FromTheWorld @posva @edison1105 @yyx990803