-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
previous fix caused regressions in nuxt
- Loading branch information
Showing
3 changed files
with
14 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1241,10 +1241,6 @@ function baseCreateRenderer( | |
if (!initialVNode.el) { | ||
const placeholder = (instance.subTree = createVNode(Comment)) | ||
processCommentNode(null, placeholder, container!, anchor) | ||
// This noramlly gets setup by the following `setupRenderEffect`. | ||
// But the call is skipped in initial mounting of async element. | ||
// Thus, manually patching is required here or it will result in a crash during parent component update. | ||
initialVNode.el = placeholder.el | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
mmis1000
Contributor
|
||
} | ||
return | ||
} | ||
|
This change seems regressed a case fixed in #7290
The crash of this playground happened again when selecting 3.4.0-beta.2
Is this accidentally removed? Or is this case not covered by accident?