Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Vue Tic Tac Toe (Reviewed) #4216

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Add: Vue Tic Tac Toe (Reviewed) #4216

merged 2 commits into from
Dec 17, 2024

Conversation

EduardoProfe666
Copy link
Contributor

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 Put an x in the boxes that apply

  • Fix
  • Feature

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • Title as described
  • Make sure you put things in the right category!
  • Always add your items to the end of a list

Open Source

  • Link description does not contain a link to an author / third-party resource
  • The documentation (README) contains a description of the project, illustration of the project with a demo or screenshots and a CONTRIBUTING section
  • The documentation is in English.
  • The project is active and maintained.
  • The project accepts contributions.
  • Not a commercial product

Apps/Websites

  • The website is available without errors or ssl certificate problems, and load in a reasonable amount of time.
  • [ x The website is using vuejs intensively. It should detect vue with vue-devtools.

    If you cannot detect vue with vue-devtools due to work at non public pages (e.g. for enterprise website), you can send Pull Request with screenshot that detected it.

  • The website is original and not too simple. For that reason, blogs and simple landing pages are rejected.
  • A commercial product using Vue, provided that guests could reasonably check out how Vue was used (i.e. A headless CMS which uses Vue for the Admin/editor Area and offers a free tier).

@Jogai
Copy link
Collaborator

Jogai commented Dec 10, 2024

Looks good, but violating the rule: Always add your items to the end of a list. To be fair, the order is first-come-first-serve.

@EduardoProfe666
Copy link
Contributor Author

I put it at the end of the list. I forgot that rule

@EduardoProfe666 EduardoProfe666 changed the title Add Vue Tic Tac Toe Add: Vue Tic Tac Toe (Reviewed) Dec 17, 2024
@Jogai Jogai merged commit c13debc into vuejs:master Dec 17, 2024
1 check failed
@Jogai
Copy link
Collaborator

Jogai commented Dec 17, 2024

With a username like that I asssumed you'd want to do some evil 😄 but its good now.

@EduardoProfe666
Copy link
Contributor Author

😂, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants