Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addTagOn triggers on russian «б» character because its the same key on keyboard #125

Closed
Grawl opened this issue Sep 13, 2021 · 6 comments

Comments

@Grawl
Copy link

Grawl commented Sep 13, 2021

Version

  • Vue version: 3

Description

I want to add tags with comma character: ,

I add it to addTagOn property of <Multiselect> component

:add-tag-on=`['enter', ',']`

And it works,

but

when I write in Russian locale, I cannot type character «б» because it adds tag instead of typing the character

its the same key on my keyboard:

image

@Grawl
Copy link
Author

Grawl commented Sep 14, 2021

It's because , and б has the same 188 keyCode in keyup event. But different key field.

Multiselect uses switch by keyCode in handleKeydown function:

https://github.com/vueform/multiselect/blob/main/src/composables/useKeyboard.js#L37

I think it should switch by key string which more specific

@stale
Copy link

stale bot commented Nov 29, 2021

Hi 👋 this issue has been automatically marked as stale 📌 because it has not had recent activity 😴. It will be closed if no further activity occurs.

@stale stale bot added the stale label Nov 29, 2021
@stale
Copy link

stale bot commented Dec 14, 2021

Hi again 👋 we would like to inform you that this issue has been automatically closed 🔒 because it had not recent activity during the stale period.

@stale stale bot closed this as completed Dec 14, 2021
@Grawl
Copy link
Author

Grawl commented Dec 14, 2021

🤦‍♂️

@adamberecz adamberecz reopened this Dec 16, 2021
@stale stale bot removed the stale label Dec 16, 2021
@adamberecz
Copy link
Collaborator

Got fixed in 2.3.0 with your proposal, which also needed a follow up with tests. Thanks for the effort anyways!

🤦‍♂️

Please keep it cool, I'm doing my best.

@Grawl
Copy link
Author

Grawl commented Jan 20, 2022

it was my reaction to bot actions, not your work. VueForm is good OSS anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants