fix(dropdown): fix close popup doesn't emit 'visibleChange' event #6416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangjinzhou
reviewed
Apr 4, 2023
| @@ -51,11 +51,12 @@ export default defineComponent({ | |||
| }); | |||
|
|
|||
| const onClick = (e: MouseEvent) => { | |||
| if (triggerVisible.value !== props.visible) { | |||
There was a problem hiding this comment.
原来那个，会有bug，我感觉可能是trigger 组件的问题，这个问题的引起可能是那个 sPopupVisible 这个状态，被两个地方进行修改，一个是监听了props.popupVisible ，另外一个是 setPopupVisible
There was a problem hiding this comment.
嗯嗯，先回滚掉，原来只是不触发 visibleChange，影响较小，可以再看看根本问题
话说 antd react 应该也有问题吧
There was a problem hiding this comment.
文档明确说了click不触发onVisibleChange，虽然这行为也挺让人难理解的
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
This is a ...
What's the background?
API Realization (Optional if not new feature)
What's the effect? (Optional if not new feature)
Changelog description (Optional if not new feature)
Self Check before Merge
Additional Plan? (Optional if not new feature)