[Feature] Deploy statically generated website #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SSG since the routing is done by vercel we no longer hit the router "before hooks". Thus i need to:
Moving to a new page doesn't scroll to the top of the page. Fix scrolling behavior in SSG. - See here.
N.B. Disabling JS seems to have a working scrolling (moves to top of the page) => build app, console logs on scrolling memoization and figure out bug fix.
Fix meta tags in SSG - See here. In SPA i put meta task directly in the document via the router's
beforeEachhook. In ssg i've tried unhead but wasn't able to make it work.Enable and update vercel json file. Currently it's disabled. Also, need to replace the legacy "routes" with "redirects" and friends.
Revert to using the SSG build script