feat(store-ui): Breadcrumb molecule #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 156d478 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6176e45f929f5400085ef2f7 😎 Browse the preview: https://deploy-preview-986--storeui.netlify.app/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 156d478:
|
igorbrasileiro
suggested changes
Oct 13, 2021
packages/store-ui/src/molecules/Breadcrumb/stories/Breadcrumb.stories.tsx
Outdated
Show resolved
Hide resolved
|
This PR closes #848 |
Closed
victorhmp
reviewed
Oct 13, 2021
victorhmp
requested changes
Oct 13, 2021
igorbrasileiro
approved these changes
Oct 21, 2021
igorbrasileiro
suggested changes
Oct 21, 2021
igorbrasileiro
approved these changes
Oct 21, 2021
Comment on lines
33
to
37
| style={{ | ||
| boxSizing: 'border-box', | ||
| fill: 'rgb(230, 230, 230)', | ||
| display: 'flex', | ||
| }} |
There was a problem hiding this comment.
This should be here?
There was a problem hiding this comment.
[Edit] Nvm what I said before, I just tested that these styles are unnecessary lol. Sorry.
victorhmp
approved these changes
Oct 21, 2021
igorbrasileiro
approved these changes
Oct 22, 2021
Gmantiqueira
force-pushed
the
feature/breadcrumb
branch
from
c55997a to
156d478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
As the title says, this PR creates the Breadcrumb molecule.
I'm not sure yet about the custom and default icons of this component, so if you have some thoughts about it, you're welcome. 😄
- Updating stores with this component (WIP).
How it works?
How to test it?
References