Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-theme-store): Use Window instead of globalThis for browser support #984

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

Gmantiqueira
Copy link
Contributor

@Gmantiqueira Gmantiqueira commented Oct 8, 2021

What's the purpose of this pull request?

Stores were breaking when running in older browsers because we're using globalThis instead of window.

It's happening only in 0.x because it's inside gatsby-theme-store.

@Gmantiqueira Gmantiqueira requested a review from a team as a code owner October 8, 2021 18:40
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b33857d:

Sandbox Source
Store UI Typescript Configuration

@Gmantiqueira Gmantiqueira merged commit 51f90c3 into 0.x Oct 14, 2021
@Gmantiqueira Gmantiqueira deleted the feat/0.x/browser-support branch October 14, 2021 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants