Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: synchronously reading regionId initial value #974

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

icazevedo
Copy link
Contributor

What's the purpose of this pull request?

This fixes an issue where regionId would be null on queries because it was being loaded lazily.

@icazevedo icazevedo requested a review from tlgimenes September 23, 2021 19:20
@icazevedo icazevedo self-assigned this Sep 23, 2021
@icazevedo icazevedo requested a review from a team as a code owner September 23, 2021 19:20
Copy link
Contributor

@Gmantiqueira Gmantiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1dc995c:

Sandbox Source
Store UI Typescript Configuration

@icazevedo icazevedo merged commit 9742da4 into 0.x Sep 23, 2021
@icazevedo icazevedo deleted the fix/region-id-initial-value branch September 23, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants