feat(store-api): Add codegen #960
Conversation
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: b8bfcfe 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/61425ed9487717000857224c 😎 Browse the preview: https://deploy-preview-960--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b8bfcfe:
|
| "test": "tsdx test", | ||
| "lint": "tsdx lint" | ||
| "lint": "tsdx lint", | ||
| "generate": "graphql-codegen --config codegen.yml" |
There was a problem hiding this comment.
How about adding a clean script here too?
There was a problem hiding this comment.
for cleaning the dist folder you mean?
There was a problem hiding this comment.
I was actually thinking about the generated types... but yeah! Hahahah the dist folder makes more sense
There was a problem hiding this comment.
Oh, every time we generate the typings it actually clean the types, so it's kinda already built into the "generate" command
| "@graphql-tools/schema": "^8.2.0", | ||
| "graphql": "^15.5.3", | ||
| "isomorphic-unfetch": "^3.1.0", |
There was a problem hiding this comment.
Why were these dependencies added?
There was a problem hiding this comment.
It was already importing these on the code but it wasn't really defined in store-api's deps.
There was a problem hiding this comment.
Can we prevent that from happening? Like, scoping dependencies per package?
What's the purpose of this pull request?
Adds graphql codegen for auto generating TypeScript typings after the graphql typeDefs for store-api.
This is important for the future once we start using these typings on our typescript code base
How it works?
Graphql codegen is a cli. This cli is hooked into the
generatescript of package.json. To generate types just:To watch for file changes:
Also, the
yarn buildcommand nows does two things: