Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-store): Add source store plugin #944

Merged
merged 5 commits into from
Sep 13, 2021

Conversation

tlgimenes
Copy link
Contributor

What's the purpose of this pull request?

Adds a new plugin called gatsby-source-store. This plugin should replace gatsby-source-vtex and works with store-api graphql schema. It sources both products and collections into the gatsby's graphql layer

@tlgimenes tlgimenes requested a review from a team as a code owner September 9, 2021 13:23
@netlify
Copy link

netlify bot commented Sep 9, 2021

✔️ Deploy Preview for storeui ready!

🔨 Explore the source changes: 2e25cc2

🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/613a0b3434f6380007bea2e8

😎 Browse the preview: https://deploy-preview-944--storeui.netlify.app/

@tlgimenes tlgimenes changed the base branch from master to feat/store-api-vtex September 9, 2021 13:25
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 9, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ca43d9:

Sandbox Source
Store UI Typescript Configuration

@tlgimenes tlgimenes force-pushed the feat/store-api-vtex branch 2 times, most recently from 47bdee9 to ec7567b Compare September 9, 2021 13:39
packages/gatsby-source-store/README.md Outdated Show resolved Hide resolved
packages/gatsby-source-store/package.json Outdated Show resolved Hide resolved
packages/gatsby-source-store/src/sourceStore.ts Outdated Show resolved Hide resolved

return response
},
gatsbyTypePrefix: ``,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just remove that?

Suggested change
gatsbyTypePrefix: ``,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is required for typescript not breaking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this property is required on the typings of this type

@tlgimenes tlgimenes force-pushed the feat/source-store branch 2 times, most recently from e77cb0e to 48621fd Compare September 12, 2021 13:14
@tlgimenes tlgimenes merged commit f6ef333 into feat/store-api-vtex Sep 13, 2021
@tlgimenes tlgimenes deleted the feat/source-store branch September 13, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants