fix(gatsby-plugin-cms): null cms nodes were preventing stores from building #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: cee6a13 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6127de18992def000899bc1b 😎 Browse the preview: https://deploy-preview-921--storeui.netlify.app |
emersonlaurentino
approved these changes
Aug 26, 2021
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cee6a13:
|
bentoper
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR fixes stores breaking the build when remote nodes were null. We observed this can occur when a page of type Institutional Page is published with no sections on it.
The CMS team will discuss it to see if that's the API format they intend to keep or if they will change the null value to a page object with empty/null fields when that happens.
How it works?
I just added a filter for null/undefined values