Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store-ui): Remove unnecessary ID and improve a11y #915

Merged
merged 3 commits into from
Aug 20, 2021
Merged

fix(store-ui): Remove unnecessary ID and improve a11y #915

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3482361
fix unnecessary id
Aug 20, 2021
03073b3
custom id
Aug 20, 2021
5f0542f
optional id prop
Aug 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/store-ui/src/molecules/Carousel/Carousel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const createTransformValues = (infinite: boolean, totalItems: number) => {
}

export interface CarouselProps extends SwipeableProps {
id?: string
testId?: string
infiniteMode?: boolean
controls?: 'complete' | 'navigationArrows' | 'paginationBullets'
Expand All @@ -44,6 +45,7 @@ function Carousel({
property: 'transform',
},
children,
id = 'store-carousel',
...swipeableConfigOverrides
}: PropsWithChildren<CarouselProps>) {
const childrenArray = React.Children.toArray(children)
Expand Down Expand Up @@ -87,7 +89,7 @@ function Carousel({

return (
<section
id="store-carousel"
id={id}
data-store-carousel
data-testid={testId}
aria-label="carousel"
Expand Down Expand Up @@ -155,7 +157,7 @@ function Carousel({
<div data-carousel-controls>
<Button
data-left-arrow
aria-controls="store-carousel"
aria-controls={id}
aria-label="previous"
onClick={() => {
if (sliderState.sliding) {
Expand All @@ -169,7 +171,7 @@ function Carousel({
</Button>
<Button
data-right-arrow
aria-controls="store-carousel"
aria-controls={id}
aria-label="next"
onClick={() => {
if (sliderState.sliding) {
Expand Down