Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(store-ui): Create Badge component #894

Merged
merged 10 commits into from
Aug 24, 2021
Merged

feat(store-ui): Create Badge component #894

merged 10 commits into from
Aug 24, 2021

Conversation

victorhmp
Copy link
Member

@victorhmp victorhmp commented Aug 13, 2021

What's the purpose of this pull request?

This PR adds the Badge component to our store-ui library.

Closes #832.

How it works?

The Badge component enables users to create their own discount (or any type of highlighted property) badges and add them to their UIs.

Here's an example on it being used to display a discount badge on top of some ProductSummary components:

Screen Shot 2021-08-23 at 11 46 12

How to test it?

Check the deploy preview below. You should find this under Atoms/Badge.

@victorhmp victorhmp self-assigned this Aug 13, 2021
@netlify
Copy link

netlify bot commented Aug 13, 2021

✔️ Deploy Preview for storeui ready!

🔨 Explore the source changes: f31a5f6

🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6125058c2a42350007d684fa

😎 Browse the preview: https://deploy-preview-894--storeui.netlify.app

@victorhmp
Copy link
Member Author

Checked for stores using the current Badge from theme-ui exported by @vtex/store-ui and didn't find any. So the breaking change introduced in this PR doesn't require extra PRs 😄

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f31a5f6:

Sandbox Source
Store UI Typescript Configuration

@emersonlaurentino emersonlaurentino linked an issue Aug 18, 2021 that may be closed by this pull request
@victorhmp victorhmp marked this pull request as ready for review August 23, 2021 15:26
@victorhmp victorhmp requested a review from a team as a code owner August 23, 2021 15:26
Copy link
Contributor

@igorbrasileiro igorbrasileiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @victorhmp 👏 !! Left some comments

packages/store-ui/src/atoms/Badge/Badge.tsx Show resolved Hide resolved
@victorhmp victorhmp merged commit 1438be3 into master Aug 24, 2021
@victorhmp victorhmp deleted the feature/badge-atom branch August 24, 2021 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge
3 participants