feat(store-ui): Overlay Atom #890
Conversation
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 9d1afcc 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/611be228da80d5000705d372 😎 Browse the preview: https://deploy-preview-890--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d1afcc:
|
|
|
||
| return ( | ||
| <div style={{ height: 'calc(100vh + 150px)' }}> | ||
| A content outside me |
There was a problem hiding this comment.
Maybe?
| A content outside me | |
| Content outside of me |
There was a problem hiding this comment.
👀 I think Content outside me is better, no? https://dictionary.cambridge.org/pt/dicionario/ingles/outside?q=outside+of
Outside vs outside of in this case has no difference. Ain't an English expert, remember this. hahha
| A content outside me | ||
| <Component | ||
| {...props} | ||
| style={{ |
There was a problem hiding this comment.
Nice! I think we can wait for #828 so we can move these styles there, what do you think?
There was a problem hiding this comment.
Yeah, for sure, np
|
Add role presentation https://www.w3.org/WAI/PF/HTML/wiki/RoleAttribute |
igorbrasileiro
force-pushed
the
feat/overlay
branch
from
9cbcd5c to
c5e8e2a
Compare
igorbrasileiro
force-pushed
the
feat/overlay
branch
2 times, most recently
from
c23b368 to
9fe233c
Compare
igorbrasileiro
force-pushed
the
feat/overlay
branch
from
9fe233c to
9d1afcc
Compare
What's the purpose of this pull request?
Adds Overlay atom: component, test, and story.
How it works?
How to test it?
References