fix(gatsby-plugin-graphql): Fix warnings and incremental builds #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
When using this plugin, we get the warnings:
These warnings are there to prevent adding two different queries with the same name. When building the same query, this warning is fires by mistake. This PR fixes this issue by tracking the filename of the query and only warning when two queries of the same name in different files are created.
Another fix this PR brings is related to incremental builds. When building incrementally, not all files will go through babel and some queries/fragments may be missing, causing a "Missing Query" error. To fix this error, we serialize the plugin's state into te file system and hydrate the plugin when building incrementally. This should fix all errors.
How to test it?
Make sure the warnings went away and incremental builds work just fine: Also, make sure queries are still generated correctly
https://github.com/vtex-sites/storecomponents.store/pull/1109
https://github.com/vtex-sites/btglobal.store/pull/785
https://github.com/vtex-sites/marinbrasil.store/pull/601