chore(gatsby-theme-store): Remove gatsby-config.js from theme-store #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 17a350a 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6114f6aaa06bed00087e1bdc 😎 Browse the preview: https://deploy-preview-888--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 17a350a:
|
tlgimenes
force-pushed
the
chore/remove-config
branch
from
b0cec89 to
e727eb4
Compare
tlgimenes
force-pushed
the
chore/remove-config
branch
from
e727eb4 to
17a350a
Compare
igorbrasileiro
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
As title says, this PR removes gatsby-config from theme-store, virtually making it a plugin. The idea being that we can use different styling systems on different stores.
How to test this PR?
This is also an architectural change and should not impact on the user's final experience. Make sure this is the case for:
https://github.com/vtex-sites/btglobal.store/pull/784
https://github.com/vtex-sites/marinbrasil.store/pull/599
https://github.com/vtex-sites/storecomponents.store/pull/1108