-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade gatsby #887
Conversation
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: e850b82 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6113e6c29f783100085731e0 😎 Browse the preview: https://deploy-preview-887--storeui.netlify.app |
2bd3fe6
to
2fdc1e6
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e850b82:
|
These results are local or on the platform? |
They are local, but the platform is about to release their version of caching. Take a look at: https://github.com/vtex-sites/storecomponents.store/pull/1106 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, awesome! Just to take note, apparently this PR fixes this issue #695 as well.
I would appreciate if anyone else can try to run a store with this version on Windows OS.
Also @tlgimenes did you check if we have changes in the bundle size? I don't know how do you do this, though. |
yes, just check |
What's the purpose of this pull request?
This PR fixes our packages when upgrading gatsby. When upgrading gatsby on each store, I got some errors on theme-store and plugin-performance.
The issue with theme-store happened because of the way we were building the package that caused gatsby to think the queries were duplicacted. To fix this issue I have added the
noEmit
option totsconfig.json
so the files are not emitted and, thus, not duplicated.The issue with plugin-performance was that they upgrade some gatsby internals and a backport was required.
The new versions of Gatsby adds some really good improvements on build times and webpack caching as well as support to functions. Some results on build performance are:
How to test it?
This is just a dep upgrade, so make sure no visual/functional regression was introduced at:
https://github.com/vtex-sites/marinbrasil.store/pull/596
https://github.com/vtex-sites/btglobal.store/pull/782
https://github.com/vtex-sites/storecomponents.store/pull/1105