Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade gatsby #887

Merged
merged 5 commits into from
Aug 12, 2021
Merged

chore: Upgrade gatsby #887

merged 5 commits into from
Aug 12, 2021

Conversation

tlgimenes
Copy link
Contributor

@tlgimenes tlgimenes commented Aug 11, 2021

What's the purpose of this pull request?

This PR fixes our packages when upgrading gatsby. When upgrading gatsby on each store, I got some errors on theme-store and plugin-performance.

The issue with theme-store happened because of the way we were building the package that caused gatsby to think the queries were duplicacted. To fix this issue I have added the noEmit option to tsconfig.json so the files are not emitted and, thus, not duplicated.

The issue with plugin-performance was that they upgrade some gatsby internals and a backport was required.

The new versions of Gatsby adds some really good improvements on build times and webpack caching as well as support to functions. Some results on build performance are:

Accounts Gatsby 3.1 Gatsby 3.11
storecomponents 64 30
marinbrasil 68 58
btglobal 52 35

How to test it?

This is just a dep upgrade, so make sure no visual/functional regression was introduced at:

https://github.com/vtex-sites/marinbrasil.store/pull/596
https://github.com/vtex-sites/btglobal.store/pull/782
https://github.com/vtex-sites/storecomponents.store/pull/1105

@netlify
Copy link

netlify bot commented Aug 11, 2021

✔️ Deploy Preview for storeui ready!

🔨 Explore the source changes: e850b82

🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6113e6c29f783100085731e0

😎 Browse the preview: https://deploy-preview-887--storeui.netlify.app

@tlgimenes tlgimenes force-pushed the chore/upgrade-gatsby branch from 2bd3fe6 to 2fdc1e6 Compare August 11, 2021 14:17
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 11, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e850b82:

Sandbox Source
Store UI Typescript Configuration

@tlgimenes tlgimenes marked this pull request as ready for review August 11, 2021 17:36
@tlgimenes tlgimenes requested a review from a team as a code owner August 11, 2021 17:36
@igorbrasileiro
Copy link
Contributor

These results are local or on the platform?

@tlgimenes
Copy link
Contributor Author

These results are local or on the platform?

They are local, but the platform is about to release their version of caching. Take a look at: https://github.com/vtex-sites/storecomponents.store/pull/1106

Copy link
Contributor

@Gmantiqueira Gmantiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, awesome! Just to take note, apparently this PR fixes this issue #695 as well.

I would appreciate if anyone else can try to run a store with this version on Windows OS.

@Gmantiqueira
Copy link
Contributor

Also @tlgimenes did you check if we have changes in the bundle size? I don't know how do you do this, though.

@tlgimenes
Copy link
Contributor Author

Also @tlgimenes did you check if we have changes in the bundle size? I don't know how do you do this, though.

yes, just check /bundle-stats.html on the Deploy previews. They are the same ;)

@tlgimenes tlgimenes merged commit a3c61bf into master Aug 12, 2021
@tlgimenes tlgimenes deleted the chore/upgrade-gatsby branch August 12, 2021 09:44
@Gmantiqueira Gmantiqueira linked an issue Aug 13, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in packages on windows
3 participants