fix(codesandbox): Prevent building twice #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 6b9839f 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/6101c6650a85140007895b40 😎 Browse the preview: https://deploy-preview-872--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6b9839f:
|
lariciamota
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Prevent codesandbox bot to build the packages twice
How it works?
Basically, Codesandbox's bot does the following commands:
The first command runs the build script for each package, whereas the second packs the built packages into a tarball.
The problem with this approach is that while running
pack, npm calls thepreparescript. The prepare script was runningyarn build, which rebuilt all packages again. This lead to longer than necessary build times in codesandbox CI and also caused inconsistencies since thepackcommand was run in parallel, not respecting the package's inter dependencies. This PR solves this problem by removing allpreparescripts. This is ok because our workflow on github actions do not use the prepare and runs build too.How to test it?
Make sure codesandbox CI is working as intended