chore(store-ui): Improve atoms pattern consistency #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 34001da 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60ef35ba47df5f0008f252ca 😎 Browse the preview: https://deploy-preview-819--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 34001da:
|
emersonlaurentino
requested changes
Jul 14, 2021
| @@ -13,18 +14,22 @@ const ButtonTemplate: Story<ButtonProps> = ({ children, onClick, testId }) => ( | |||
|
|
|||
| export const Button = ButtonTemplate.bind({}) | |||
|
|
|||
| const constrols: ComponentArgTypes<ButtonProps> = { | |||
There was a problem hiding this comment.
Suggested change
| const constrols: ComponentArgTypes<ButtonProps> = { | |
| const argTypes: ComponentArgTypes<ButtonProps> = { |
| table: { disable: true }, | ||
| }, | ||
| } | ||
|
|
||
| export default { | ||
| title: 'Atoms/Button', | ||
| component: Button, | ||
| argTypes: { |
There was a problem hiding this comment.
Suggested change
| argTypes: { | |
| argTypes, |
Comment on lines
32
to
33
| ...constrols, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| ...constrols, | |
| }, |
|
|
||
| const IconTemplate: Story<IconProps> = ({ style }) => ( | ||
| <Component style={style} component={<ShoppingCart />} /> | ||
| ) | ||
|
|
||
| export const Icon = IconTemplate.bind({}) | ||
|
|
||
| const controls: ComponentArgTypes<Omit<IconProps, 'component'>> = { |
There was a problem hiding this comment.
Suggested change
| const controls: ComponentArgTypes<Omit<IconProps, 'component'>> = { | |
| const argTypes: ComponentArgTypes<Omit<IconProps, 'component'>> = { |
| table: { disable: true }, | ||
| }, | ||
| } | ||
|
|
||
| export default { | ||
| title: 'Atoms/Icon', | ||
| component: Icon, | ||
| argTypes: { |
There was a problem hiding this comment.
Suggested change
| argTypes: { | |
| argTypes, |
| table: { disable: true }, | ||
| }, | ||
| } | ||
|
|
||
| export default { | ||
| title: 'Molecules/Bullets', | ||
| component: Bullets, | ||
| argTypes: { |
There was a problem hiding this comment.
Suggested change
| argTypes: { | |
| argTypes, |
Comment on lines
48
to
49
| ...controls, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| ...controls, | |
| }, |
| @@ -22,17 +23,21 @@ const CustomIconTemplate: Story<SearchInputProps> = ({ | |||
|
|
|||
| export const CustomIcon = CustomIconTemplate.bind({}) | |||
|
|
|||
| const controls: ComponentArgTypes<SearchInputProps> = { | |||
There was a problem hiding this comment.
Suggested change
| const controls: ComponentArgTypes<SearchInputProps> = { | |
| const argTypes: ComponentArgTypes<SearchInputProps> = { |
| table: { disable: true }, | ||
| }, | ||
| } | ||
|
|
||
| export default { | ||
| title: 'Molecules/SearchInput', | ||
| argTypes: { |
There was a problem hiding this comment.
Suggested change
| argTypes: { | |
| argTypes, |
Comment on lines
40
to
41
| ...controls, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| ...controls, | |
| }, |
tlgimenes
approved these changes
Jul 14, 2021
igorbrasileiro
force-pushed
the
chore/store-ui
branch
from
182b2a0 to
b9f2d14
Compare
emersonlaurentino
approved these changes
Jul 14, 2021
igorbrasileiro
force-pushed
the
chore/store-ui
branch
from
b9f2d14 to
34001da
Compare
Gmantiqueira
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Create type to avoid wrong props inside StoryBook argtypes * Change TextArea state prop to variant * Change Input state prop to variant * Improve atoms argtypes type * Improve molecules argtypes * Fix Checkbox export * Fix request changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Added:
Changed:
How it works?
How to test it?
https://github.com/vtex-sites/btglobal.store/pull/708
References