feat(store-ui): Checkbox atom component #813
Conversation
|
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 520c767 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60e888d0b1bf7c000733081e 😎 Browse the preview: https://deploy-preview-813--storeui.netlify.app |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 520c767:
|
|
|
||
| describe('Checkbox', () => { | ||
| it('data-store-checkbox is present', () => { | ||
| const { getByTestId } = render(<Checkbox testId="checkbox" />) |
There was a problem hiding this comment.
| const { getByTestId } = render(<Checkbox testId="checkbox" />) | |
| const { getByTestId } = render(<Checkbox testId="store-checkbox" />) |
There was a problem hiding this comment.
Passing the testId, instead of using the default one, prevents break the test furthermore, what do you think?
There was a problem hiding this comment.
You have a point. Maybe really better pass the testid.
| it('data-store-checkbox is present', () => { | ||
| const { getByTestId } = render(<Checkbox testId="checkbox" />) | ||
|
|
||
| expect(getByTestId('checkbox')).toHaveAttribute('data-store-checkbox') |
There was a problem hiding this comment.
| expect(getByTestId('checkbox')).toHaveAttribute('data-store-checkbox') | |
| expect(getByTestId('store-checkbox')).toHaveAttribute('data-store-checkbox') |
| }) | ||
|
|
||
| it('type checkbox is present', () => { | ||
| const { getByTestId } = render(<Checkbox testId="checkbox" />) |
There was a problem hiding this comment.
| const { getByTestId } = render(<Checkbox testId="checkbox" />) | |
| const { getByTestId } = render(<Checkbox testId="store-checkbox" />) |
| it('type checkbox is present', () => { | ||
| const { getByTestId } = render(<Checkbox testId="checkbox" />) | ||
|
|
||
| expect(getByTestId('checkbox')).toHaveAttribute('type', 'checkbox') |
There was a problem hiding this comment.
| expect(getByTestId('checkbox')).toHaveAttribute('type', 'checkbox') | |
| expect(getByTestId('store-checkbox')).toHaveAttribute('type', 'checkbox') |
But the CSS already has it |
igorbrasileiro
changed the title
|
In the storybook, is it possible to create a boolean control to check the checkbox? Also, I'd like to see if we can add an action there too so we can listen to when a checkbox has been checked |
igorbrasileiro
force-pushed
the
feature/checkbox-atom
branch
from
664bcf2 to
5a3a164
Compare
|
@tlgimenes and @emersonlaurentino I did your request changes. |
|
@igorbrasileiro the tip of @tlgimenes is great! |
If I understood well, it's to create a control for checked property and an action for the click event, I did it also. |
The default value is already false, but it's not explicitly defined. It seems a bug because the query string on the URL doesn't work, but you can remove the query string or navigate to another story and go back. |
What's the purpose of this pull request?
Add the Checkbox atom to store-ui
How it works?
How to test it?
References