Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphql error messages being swallowed up #804

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

lbebber
Copy link
Contributor

@lbebber lbebber commented Jul 2, 2021

What's the purpose of this pull request?

As the title says

Before
Screen Shot 2021-07-02 at 19 19 49

After
Screen Shot 2021-07-02 at 19 19 58

How it works?

How to test it?

References

@lbebber lbebber requested a review from a team as a code owner July 2, 2021 22:18
@netlify
Copy link

netlify bot commented Jul 2, 2021

✔️ Deploy Preview for storeui ready!

🔨 Explore the source changes: 47a944b

🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60df90c82a1f45000797d6e8

😎 Browse the preview: https://deploy-preview-804--storeui.netlify.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 47a944b:

Sandbox Source
Store UI Typescript Configuration

Copy link
Contributor

@tlgimenes tlgimenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just don't forget to use conventional commits before merging

@tlgimenes tlgimenes changed the title Fix graphql error messages being swallowed up fix: graphql error messages being swallowed up Jul 5, 2021
@tlgimenes tlgimenes merged commit 4396e88 into master Jul 5, 2021
@tlgimenes tlgimenes deleted the fix/graphql-error-message branch July 5, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants