-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 'Bullets' molecule #786
Conversation
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 64b832c 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60d4eb351b91e000076e2937 😎 Browse the preview: https://deploy-preview-786--storeui.netlify.app/iframe |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 64b832c:
|
@Gmantiqueira Check the storybook here 😉 |
packages/store-ui/src/molecules/Bullets/stories/Bullets.stories.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's the purpose of this pull request?
This PR adds the Bullets molecule to our store-ui library.
How it works?
The
Bullets
molecule is supposed to be used in scenarios where we have paginated items, which can be navigated through the use of small bullets indicating where the user is and where they can go to. This is commonly used along with Carousels, such as this example:The
Bullets
molecule would be used to make those small circles at the bottom of the image. And it supports the following props:To enable different CSS rules to be applied to the current bullet set as 'active', we render the currently active bullet with a data attribute
data-active
.How to test it?
You can check the deploy preview linked below, where you'll find a
Bullets
section listed underMolecules
in our Storybook.Take a look at the
Story
section to see the code being used to control theBullets
molecule.