-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Price atom #760
feat: Price atom #760
Conversation
✔️ Deploy Preview for storeui ready! 🔨 Explore the source changes: 2693909 🔍 Inspect the deploy log: https://app.netlify.com/sites/storeui/deploys/60c8eae974e10d00086da244 😎 Browse the preview: https://deploy-preview-760--storeui.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2693909:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand the listing
proposal. Can you explain?
3621534
to
2693909
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job @icazevedo 🎉
* Adding Price atom to store-ui * Removing unused children arg from Price storybook * Adding variant to Price and memoizing storybook formatters * Removing useless condition on Price atom * Fixing default variant name and data attributes on Price atom * Exporting Price component
What's the purpose of this pull request?
This PR adds the Price atom to our store-ui library.
UI
Styling