feat: Gets user's saved location if logged in and uses in session #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
hellofanny
changed the title
hellofanny
changed the title
hellofanny
commented
Mar 21, 2025
hellofanny
force-pushed
the
feat/profile-address-location
branch
from
884aac3 to
942ecf6
Compare
hellofanny
requested review from
eduardoformiga and
lariciamota
and removed request for
a team
lucasfp13
reviewed
Mar 21, 2025
packages/api/src/platforms/vtex/clients/profile/types/ProfileAddress.ts
Outdated
Show resolved
Hide resolved
Comment on lines
343
to
353
| const addresses = await profile.addresses(userId) | ||
|
|
||
| function mapAddressesToList(AddressesObj: any): ProfileAddress[] { | ||
| if (!addresses || Object.keys(addresses).length === 0) { | ||
| return [] | ||
| } | ||
|
|
||
| return Object.values<string>(AddressesObj).map( | ||
| (stringifiedObj) => JSON.parse(stringifiedObj) as ProfileAddress | ||
| ) | ||
| } |
There was a problem hiding this comment.
question: addresses is already of type ProfileAddress[], I didn't get it why you considered as any at line 345. What is the shape of ProfileAddress[] incoming from API?
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR implements the scenario where the user is logged in, and when the user's saved location (address and geo-coordinates) is available, it is saved in the current session.
How it works?
How to test it?
First, we will need to simulate user logged. (you can follow this docs steps with more detail or follow the steps below)
personobject with user's information (that was previouslynull)postalCodeandgeoCoordinatesin the sessionStarters Deploy Preview
vtex-sites/starter.store#731
Jira Task