feat: create ProgressBar component #2637
Open
+82
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
artursantiago
requested review from
eduardoformiga and
lucasfp13
and removed request for
a team
|
Can you add the preview on storybook? |
I just fixed the preview link. You can test it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This pull request adds the ProgressBar component. Initially, this component will be used in the Reviews & Ratings section of the product page to display the percentage of each star rating from the reviews.
How it works?
This PR introduces the
ProgressBarmolecule component. It acceptsvalue,min, andmaxas props, with default values set to0forvalue,0formin, and100formax.To ensure the interface remains stable, the component includes a safeguard mechanism: if there is any inconsistency in the props (e.g.,
minbeing greater thanmax), asafeMaxvalue is calculated to prevent the interface from breaking.How to test it?
Starters Deploy Preview
Preview
References
JIRA TASK: SFS-2066
Figma