-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add showSponsored as api configuration on faststore.config.js to IntelligentSearch integration #2438
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
f50b42c
to
14d8de3
Compare
ef6c86c
to
3cfabb0
Compare
@@ -1560,6 +1578,7 @@ export type ClientSearchSuggestionsQueryQuery = { | |||
value: any | |||
valueReference: any | |||
}> | |||
advertisement: { adId: string; adResponseId: string } | null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Was this line updated manually?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. This line is based on this fragment here.
@fltiago What is the performance of the full text search page in the Starter? |
I added in the PR description or did you mean on the original starter page? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
""" | ||
Advertisement information about the product. | ||
""" | ||
advertisement: Advertisement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In FastStore, we follow schema.org to define new props, and schema.org does not have an advertisement prop for Product that fits better for advertisement (maybe additionalProperty ?). In this case, I think we can proceed with the advertisement prop and propose this new field to schema.org somehow. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know we used a well-defined partner for our schemas, seems awesome.
I agree and I will study schema.org to see how advertisement
will fit, but first I think we should test and see how it goes.
What's the purpose of this pull request?
This PR adds support for showing sponsored products when using Intelligent Search. FastShop and probably more retailers are interested in our ad solution (VTEX Ad Network). This PR intends to create a frictionless integration between FastStore and VTEX Ad Network.
How it works?
The store will change the showSponsored configuration on the faststore.config.js file to allow intelligent search to return sponsored products. This will only happen if the store is a active publisher on VTEX Ad Network.
On faststore.config.js
How to test it?
showSponsored
attribute totrue
on faststore.config.jsCheck the starter page with the
showSponsored
flag to true and no label: Starter With Ads - related PR:Example with no label:
![image](https://private-user-images.githubusercontent.com/384326/369394602-119baa57-a5b8-4b7f-99c1-954aaae30e07.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDA0NTksIm5iZiI6MTczOTQwMDE1OSwicGF0aCI6Ii8zODQzMjYvMzY5Mzk0NjAyLTExOWJhYTU3LWE1YjgtNGI3Zi05OWMxLTk1NGFhYWUzMGUwNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMjQyMzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03Y2IxNmJkZjc2ODEzMmJkNGJjMWU2ZjhmOTVmNGNkNGUzY2JiNzE1MzFiZTkzZTZiMzlhNGM1ZWY0ZDFmMGNhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.spuLbB7B_6dV5sx5qZrQbpElfztaYRBcqtPblegwUJM)
Perfomance for category page:
![image](https://private-user-images.githubusercontent.com/384326/369394842-714db14c-a3b4-435c-9acd-5c34f43d37b6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDA0NTksIm5iZiI6MTczOTQwMDE1OSwicGF0aCI6Ii8zODQzMjYvMzY5Mzk0ODQyLTcxNGRiMTRjLWEzYjQtNDM1Yy05YWNkLTVjMzRmNDNkMzdiNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMjQyMzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mZjZmNzQ5MWU5MGIxOGJjNzQ3MDQ1MTE1YjQ0YjUwYjc2Y2Y2MjZmZTJjY2FlMDQwYmMxNjM1ZWU2ZmE5NDY1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.9bWkmPXdiTVE8u1CcBdbNLPmqXy45c_RENsERrFHwBw)
![image](https://private-user-images.githubusercontent.com/384326/369394930-e9d64b9d-aba5-4987-8477-21ebd6f0ce08.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDA0NTksIm5iZiI6MTczOTQwMDE1OSwicGF0aCI6Ii8zODQzMjYvMzY5Mzk0OTMwLWU5ZDY0YjlkLWFiYTUtNDk4Ny04NDc3LTIxZWJkNmYwY2UwOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMjQyMzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00YWQxNTAxOGFmODQ0ZjA2NDY4ZDk0OWI5ZGY1Y2M4NWI5ZDY5YjAxM2FlMjllZjgwZDZkYzRiNjI2ZjhmOTdiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.XKHRyy-dOmE0n8n2fCwkm6u80TgmP7NkrWG-T8lyJjo)
Performance for full text search page:
![image](https://private-user-images.githubusercontent.com/384326/369395782-de06dc1a-c2a5-47ec-814b-5ef6dada863c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDA0NTksIm5iZiI6MTczOTQwMDE1OSwicGF0aCI6Ii8zODQzMjYvMzY5Mzk1NzgyLWRlMDZkYzFhLWMyYTUtNDdlYy04MTRiLTVlZjZkYWRhODYzYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMjQyMzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03Y2U5MWQzMjY2YjhiNmU2M2FlNzhhNzRlMmFkZGQ2ZmRjMjkyYzljMmU5YzcxMGYwZTg3YjEwMDVjMzEwNjJjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.kTaF0E5TJHLbCyPc7QyFOGZfqCUsNIZHGZHiH2SuhiU)
![image](https://private-user-images.githubusercontent.com/384326/369395574-ce2c910f-6b46-48d2-91a6-fbe6fd62b0d6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MDA0NTksIm5iZiI6MTczOTQwMDE1OSwicGF0aCI6Ii8zODQzMjYvMzY5Mzk1NTc0LWNlMmM5MTBmLTZiNDYtNDhkMi05MWE2LWZiZTZmZDYyYjBkNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQyMjQyMzlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01NWU4NDI2YmIwNjMyNTFkZTdmNWE5MzYyNTMxNjEzMDk1NzRhZjkxMThlYTY3ZmExNzI3YjU3ODk0ZjViMjYyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.NIoOu4Nnh8me9eDKFKihR3wSkxYamh_IWvzdj2lrdVk)
Starters Deploy Preview
References